Skip to content

Fix customers/{customerId}/metafields GET responses #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix customers/{customerId}/metafields GET responses #917

merged 1 commit into from
Apr 29, 2025
+27 −102

Conversation

tvhees
Copy link
Contributor

@tvhees tvhees commented Apr 24, 2025

What changed?

  • Delete incorrect responses/MetafieldCollectionResponse component
  • Add correct 200 response for GET /v3/customers/{customerId}/metafields
  • Add correct 200 response for GET /v3/customers/{customerId}/metafields/{metafieldId}

Release notes draft

  • Fixed API documentation for GET /v3/customers/{customerId}/metafields and GET /v3/customers/{customerId}/metafields/{metafieldId} responses

Anything else?

Fixes #912

@tvhees
Update customers.v3.yml metafield responses

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
13af6f1 
This should fix bigcommerce#912

I've followed the pattern set in catalog/products_catalog.v3.yml
@bc-terra
Copy link
Contributor

This looks great. I'm going to get someone to run a secondary review to make sure I didn't miss something obvious.

@tvhees
Copy link
Contributor Author

tvhees commented Apr 26, 2025

Thanks @bc-terra!

snaderiBC
snaderiBC approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@snaderiBC snaderiBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving our docs 👏

@bc-terra bc-terra merged commit b2226ee into bigcommerce:main Apr 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaderiBC snaderiBC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response components for customer/metafields REST requests to Management API does not match runtime responses
3 participants
@tvhees @bc-terra @snaderiBC