Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: give write-all permissions for releasing #1513

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

chanceaclark
Copy link
Contributor

What/why?

After doing a bit more digging into permissions for GitHub Actions, by default we are given read/write permissions for most scopes: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

However, when we set the permissions key, it unsets the rest of the scope to no access:

When the permissions key is used, all unspecified permissions are set to no access, with the exception of the metadata scope, which always gets read access.

Changesets works with the default permissions and they don't provide a lot of guidance on which scopes they need. The existing scopes (pre-pull request) were part of some speculation in a GitHub issue on what changesets needs, but it's not the case anymore.

For the actions/deploy-page action we have every scope we need in the default permissions, besides id-token which we need to verify that the deployment was successful. This gives the token all the permissions it need in order to run the action.

@chanceaclark chanceaclark requested review from a team as code owners August 21, 2024 18:59
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 77bda18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chanceaclark chanceaclark merged commit 7197747 into main Aug 21, 2024
11 checks passed
@chanceaclark chanceaclark deleted the chore/more-permissions branch August 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants