Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] use full width entity page #1784

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Apr 15, 2024

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (943c20e) to head (df804cb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review April 15, 2024 14:49
@Remi-Gau Remi-Gau requested review from tsalo and sappelhoff April 15, 2024 14:49
@Remi-Gau Remi-Gau added the formatting Aesthetics and formatting of the spec label Apr 16, 2024
@effigies
Copy link
Collaborator

Definitely an improvement, but losing navigation doesn't seem great. Maybe just hide the TOC?

Once squidfunk/mkdocs-material#3428 exists, we could see about starting navigation in collapsed mode.

@Remi-Gau
Copy link
Collaborator Author

Definitely an improvement, but losing navigation doesn't seem great. Maybe just hide the TOC?

Let me try.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still an improvement over the old, and it doesn't leave the user stranded, only able to get back to the index.

@effigies
Copy link
Collaborator

Updated original comment with new screenshot.

@tsalo Would you mind being a second pair of eyes?

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@effigies effigies merged commit 53eafda into bids-standard:master Apr 18, 2024
26 checks passed
@Remi-Gau Remi-Gau deleted the full_width_entity_page branch October 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants