-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] use full width entity page #1784
[ENH] use full width entity page #1784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1784 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
Definitely an improvement, but losing navigation doesn't seem great. Maybe just hide the TOC? Once squidfunk/mkdocs-material#3428 exists, we could see about starting navigation in collapsed mode. |
Let me try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still an improvement over the old, and it doesn't leave the user stranded, only able to get back to the index.
Updated original comment with new screenshot. @tsalo Would you mind being a second pair of eyes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
closes none
Tiny tweak that helps for all tables but that of MRI.
Before
https://bids-specification.readthedocs.io/en/latest/appendices/entity-table.html#biopotential-amplification-eeg-and-ieeg
After
https://bids-specification--1784.org.readthedocs.build/en/1784/appendices/entity-table.html