Skip to content

Improvements on dependencies calculations #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

nbeliy
Copy link
Collaborator

@nbeliy nbeliy commented Feb 21, 2021

Metadata treatment

Split get_metadata into two functions:

  • metalist = get_meta_list(filename, pattern) returns list of files satisfying pattern with inheritance principle
  • get_metadata(metafile) construct meta structure from json files in passed meta-files list (from above function)

Each data file in dataset receives new field metafile that contains list of files from get_meta_list.

This will facilitate access to metafiles directly. Individual values can be extracted by user if needed using get_metadata.

Dependencies

Each file structure contains dependencies sub-structure with guaranteed fields:

  • explicit -- list of data files containing "IntendedFor" referencing current file.
  • data -- list of files with same name but different extension. This will combine files that are split in header and data (like in Brainvision), also takes care of bval/bvec files
  • group -- list of files that have same name except extension and suffix. This will group file that logically need each other, like functional mri and events tabular file. It also takes care of fmap magnitude1/2 and phasediff

Additional custom subfields can be added for given modalities.

This allow to treat dwi and fmap with generic parse_using_schema. perf likely also, but I can't certify it.

Issues

  • performance. I feel that retrieval of dependencies can be optimised
  • Tests -- was unable to install moxunit
  • Tests on other datasets

@Remi-Gau
Copy link
Collaborator

@nbeliy Thanks for sending this. I hope to be able to have a look at it towards the end of the week.
Sorry for the delay

@Remi-Gau
Copy link
Collaborator

moved to #172

@Remi-Gau Remi-Gau closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants