feat(tui): show scrollbar for long tables - #69
Open
ychampion wants to merge 1 commit into
Open
Conversation
Constraint: Keep sticky headers and table width unchanged. Rejected: An always-visible scrollbar | Short tables should keep the existing uncluttered border. Confidence: high Scope-risk: narrow Directive: Derive the indicator from the existing vertical offset rather than adding separate scroll state. Tested: cargo test; cargo test --no-default-features --bin xleak; strict all-target Clippy with all and no-default features; default and no-default release builds; 80x24 PTY top, bottom, and short-table smokes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Large tables can scroll vertically, but there is no visual indication of the current position. The indicator stays on the existing right border and is omitted when all rows fit.
Fixes #38.
Validation
cargo test- 67 unit and 39 integration tests passedcargo test --no-default-features --bin xleak- 66 tests passedcargo clippy --all-targets --all-features -- -D warnings- passedcargo clippy --all-targets --no-default-features -- -D warnings- passedcargo build --release --all-features- passedcargo build --release --no-default-features- passedcargo fmt --all -- --check- passed