MainnetSwapSteward #3
Conversation
|
@sakulstra after discussing internally, we've added the budget limitation to the contract. for deployment, we'll prepare an ARFC with the right parameters for the initial budgets based on historical swaps the DAO has conducted. |
There was a problem hiding this comment.
After looking into Swapper honestly to me the design of this is not so optimal.
The permissioned steward calls a permissioned, upgreadable contract(that in fact does not use upgreadable variants of the contracts).
My suggestion would be the following:
- merge this steward & aave swapper together.
- use a permissionless rescuable as on ClinicSteward, because the contract should never hold funds, right?
- this will simplify the contract a bit as e.g. recipient can be hardcoded (i think there's probably more that can be simplified)
- inline the
CollectorUtilsswap.
- swapper will always be the contract itself
- oracle decimals are already checked when registering the oracle
- the uint.max path should probably be moved to
tokenSwapand take into account available budget
| import {ICollector} from "aave-v3-origin/contracts/treasury/ICollector.sol"; | ||
| import {CollectorUtils as CU} from "aave-helpers/src/CollectorUtils.sol"; | ||
| import {MiscEthereum} from "aave-address-book/MiscEthereum.sol"; | ||
| import {IAggregatorInterface} from "src/finance/interfaces/IAggregatorInterface.sol"; |
There was a problem hiding this comment.
better to do relative imports, otherwise remappings are hell to work with.
| import {CollectorUtils as CU} from "aave-helpers/src/CollectorUtils.sol"; | ||
| import {MiscEthereum} from "aave-address-book/MiscEthereum.sol"; | ||
| import {IAggregatorInterface} from "src/finance/interfaces/IAggregatorInterface.sol"; | ||
|
|
| tokenBudget[fromToken] -= amount; | ||
|
|
||
| COLLECTOR.swap( | ||
| address(SWAPPER), CU.SwapInput(milkman, priceChecker, fromToken, toToken, fromOracle, toOracle, amount, slippage) |
There was a problem hiding this comment.
when using so many params, better to use {} object format to ensure they are passed in correct order.
Changelog
Add mainnet steward to perform swaps.
Add interface.
Add tests.