Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Risk parameters for Aave Polygon V3 - Review #636

Merged
merged 9 commits into from
Mar 3, 2025
Merged

Adjust Risk parameters for Aave Polygon V3 - Review #636

merged 9 commits into from
Mar 3, 2025

Conversation

marczeller
Copy link
Contributor

@marczeller marczeller commented Feb 28, 2025 •
edited
Loading

Ready for review

@marczeller marczeller changed the title Adjust Risk parameters for Aave Polygon V3 - WIP Adjust Risk parameters for Aave Polygon V3 - Review Feb 28, 2025
TepNik
TepNik previously approved these changes Mar 3, 2025
View reviewed changes
@marczeller @ianflexa
Update src/20250228_AaveV3Polygon_AdjustAavePolygonV3RiskParameters/A…
06f1c1a 
…djustAavePolygonV3RiskParameters.md

Co-authored-by: Ian Flexa <[email protected]>
marczeller and others added 3 commits March 3, 2025 13:04
@marczeller @ianflexa
Update src/20250228_AaveV3Polygon_AdjustAavePolygonV3RiskParameters/A…
491d043 
…djustAavePolygonV3RiskParameters.md

Co-authored-by: Ian Flexa <[email protected]>
@marczeller @ianflexa
Update src/20250228_AaveV3Polygon_AdjustAavePolygonV3RiskParameters/A…
fcf9eb0 
…djustAavePolygonV3RiskParameters.md

Co-authored-by: Ian Flexa <[email protected]>
@marczeller @ianflexa
Update src/20250228_AaveV3Polygon_AdjustAavePolygonV3RiskParameters/A…
b3d26c4 
…djustAavePolygonV3RiskParameters.md

Co-authored-by: Ian Flexa <[email protected]>
ianflexa
ianflexa previously approved these changes Mar 3, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

🌈Test Results Compiling 353 files with Solc 0.8.22 Solc 0.8.22 finished in 173.09s Compiler run successful! 2025-03-03T12:39:51.588178Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.17", "diff-snapshots", "./reports/AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228_before.json", "./reports/AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228_after.json", "-o", "./diffs/AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228_before_AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\nfile:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:948\n address: bytes32ToAddress(raw[contract].stateDiff[erc1967ImplSlot].previousValue)\n ^\n\nTypeError: Cannot read properties of undefined (reading 'previousValue')\n at file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:948:82\n at Array.map ()\n at diffRawStorage (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:929:22)\n at diffReports (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:1084:5)\n at Command. (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:1133:27)\n at Command.listener [as _actionHandler] (/home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/commander/lib/command.js:542:17)\n at /home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/commander/lib/command.js:1502:14\n at Command._chainOrCall (/home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/commander/lib/command.js:1386:12)\n at Command._parseCommand (/home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/commander/lib/command.js:1501:27)\n at /home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/commander/lib/command.js:1265:27\n\nNode.js v20.18.3\n"

Ran 1 test for src/20250228_AaveV3Polygon_AdjustAavePolygonV3RiskParameters/AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228.t.sol:AaveV3Polygon_AdjustAavePolygonV3RiskParameters_20250228_Test
[PASS] test_defaultProposalExecution() (gas: 74803905)
Logs:
0x8f3Cf7ad23Cd3CaDbD9735AFf958023239c6A063
0x53E0bca35eC356BD5ddDFebbD1Fc0fD03FaBad39
0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174
0x1BFD67037B42Cf73acF2047067bd4F2C47D9BfD6
0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619
0xc2132D05D31c914a87C6611C10748AEb04B58e8F
0x0d500B1d8E8eF31E21C99d1Db9A6444d3ADf1270
0x172370d5Cd63279eFa6d502DAB29171933a610AF
0x0b3F868E0BE5597D5DB7fEB59E1CADBb0fdDa50a
0x385Eeac5cB85A38A9a07A70c73e0a3271CfB54A7
0x9a71012B13CA4d3D0Cdc72A177DF3ef03b0E76A3
0x85955046DF4668e1DD369D2DE9f3AEB98DD2A369
0xE111178A87A3BFf0c8d18DECBa5798827539Ae99
0x4e3Decbb3645551B8A19f0eA1678079FCB33fB4c
0xE0B52e49357Fd4DAf2c15e02058DCE6BC0057db4
0xa3Fa99A148fA48D14Ed51d610c367C61876997F1
0xfa68FB4628DFF1028CFEc22b4162FCcd0d45efb6
0x03b54A6e9a984069379fae1a4fC4dBAE93B3bCCD
0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359
E2E: Collateral LINK, TestAsset DAI
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: DAI, Amount: 10002566458501922423255
WITHDRAW: DAI, Amount: 5001283229250961211627
WITHDRAW: DAI, Amount: 5001283229250961211629
BORROW: DAI, Amount 10002566458501922423255
REPAY: DAI, Amount: 10002566458501922423255
REPAY: DAI, Amount: 10002566458501922423255
BORROW: DAI, Amount 10002566458501922423255
LIQUIDATE: DAI, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002566458501922423255
LIQUIDATE: DAI, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002566458501922423255
FLASH LOAN: DAI, Amount: 10002566458501922423255
FLASH LOAN: DAI, Amount: 10002566458501922423255
E2E: Collateral LINK, TestAsset LINK
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: LINK, Amount: 677586010396608709121
WITHDRAW: LINK, Amount: 338793005198304354560
WITHDRAW: LINK, Amount: 338793005198304354561
BORROW: LINK, Amount 677586010396608709121
REPAY: LINK, Amount: 677586010396608709121
REPAY: LINK, Amount: 677586010396608709121
BORROW: LINK, Amount 677586010396608709121
LIQUIDATE: LINK, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 677586010396608709121
LIQUIDATE: LINK, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 677586010396608709121
FLASH LOAN: LINK, Amount: 677586010396608709121
FLASH LOAN: LINK, Amount: 677586010396608709121
E2E: Collateral LINK, TestAsset USDC
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: USDC, Amount: 10002950870
WITHDRAW: USDC, Amount: 5001475435
WITHDRAW: USDC, Amount: 5001475435
BORROW: USDC, Amount 10002950870
REPAY: USDC, Amount: 10002950870
REPAY: USDC, Amount: 10002950870
BORROW: USDC, Amount 10002950870
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002950871
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002950871
FLASH LOAN: USDC, Amount: 10002950870
FLASH LOAN: USDC, Amount: 10002950870
E2E: Collateral LINK, TestAsset WBTC
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: WBTC, Amount: 11858036
WITHDRAW: WBTC, Amount: 5929018
WITHDRAW: WBTC, Amount: 5929018
BORROW: WBTC, Amount 11858036
REPAY: WBTC, Amount: 11858036
REPAY: WBTC, Amount: 11858036
BORROW: WBTC, Amount 11858036
LIQUIDATE: WBTC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 11858036
LIQUIDATE: WBTC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 11858036
FLASH LOAN: WBTC, Amount: 11858036
FLASH LOAN: WBTC, Amount: 11858036
E2E: Collateral LINK, TestAsset WETH
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: WETH, Amount: 4498186706893799727
WITHDRAW: WETH, Amount: 2249093353446899863
WITHDRAW: WETH, Amount: 2249093353446899863
BORROW: WETH, Amount 4498186706893799727
REPAY: WETH, Amount: 4498186706893799727
REPAY: WETH, Amount: 4498186706893799727
BORROW: WETH, Amount 4498186706893799727
LIQUIDATE: WETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 4498186706893799727
LIQUIDATE: WETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 4498186706893799727
FLASH LOAN: WETH, Amount: 4498186706893799727
FLASH LOAN: WETH, Amount: 4498186706893799727
E2E: Collateral LINK, TestAsset USDT
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: USDT, Amount: 10004543263
WITHDRAW: USDT, Amount: 5002271631
WITHDRAW: USDT, Amount: 5002271632
BORROW: USDT, Amount 10004543263
REPAY: USDT, Amount: 10004543263
REPAY: USDT, Amount: 10004543263
BORROW: USDT, Amount 10004543263
LIQUIDATE: USDT, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10004543263
LIQUIDATE: USDT, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10004543263
FLASH LOAN: USDT, Amount: 10004543263
FLASH LOAN: USDT, Amount: 10004543263
E2E: Collateral LINK, TestAsset AAVE
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: AAVE, Amount: 52424882656163650943
WITHDRAW: AAVE, Amount: 26212441328081825471
WITHDRAW: AAVE, Amount: 26212441328081825471
FLASH LOAN: AAVE, Amount: 52424882656163650943
E2E: Collateral LINK, TestAsset WPOL
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: WPOL, Amount: 36725293701355053161698
WITHDRAW: WPOL, Amount: 18362646850677526580849
WITHDRAW: WPOL, Amount: 18362646850677526580849
BORROW: WPOL, Amount 36725293701355053161698
REPAY: WPOL, Amount: 36725293701355053161698
REPAY: WPOL, Amount: 36725293701355053161698
BORROW: WPOL, Amount 36725293701355053161698
LIQUIDATE: WPOL, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 36725293701355053161697
LIQUIDATE: WPOL, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 36725293701355053161697
FLASH LOAN: WPOL, Amount: 36725293701355053161698
FLASH LOAN: WPOL, Amount: 36725293701355053161698
E2E: TestAsset CRV SKIPPED
E2E: TestAsset SUSHI SKIPPED
E2E: Collateral LINK, TestAsset GHST
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: GHST, Amount: 19309736397767902606941
WITHDRAW: GHST, Amount: 9654868198883951303470
WITHDRAW: GHST, Amount: 9654868198883951303471
FLASH LOAN: GHST, Amount: 19309736397767902606941
E2E: TestAsset BAL SKIPPED
E2E: TestAsset DPI SKIPPED
E2E: Collateral LINK, TestAsset EURS
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: EURS, Amount: 963771
WITHDRAW: EURS, Amount: 481885
WITHDRAW: EURS, Amount: 481886
BORROW: EURS, Amount 963771
REPAY: EURS, Amount: 963771
REPAY: EURS, Amount: 963771
BORROW: EURS, Amount 963771
LIQUIDATE: EURS, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 963771
LIQUIDATE: EURS, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 963771
FLASH LOAN: EURS, Amount: 963771
FLASH LOAN: EURS, Amount: 963771
E2E: TestAsset jEUR SKIPPED
E2E: TestAsset EURA SKIPPED
E2E: TestAsset miMATIC SKIPPED
E2E: TestAsset stMATIC SKIPPED
E2E: Collateral LINK, TestAsset MaticX
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: MaticX, Amount: 32012541745554906519056
WITHDRAW: MaticX, Amount: 16006270872777453259528
WITHDRAW: MaticX, Amount: 16006270872777453259527
BORROW: MaticX, Amount 32012541745554906519056
REPAY: MaticX, Amount: 32012541745554906519056
REPAY: MaticX, Amount: 32012541745554906519056
BORROW: MaticX, Amount 32012541745554906519056
LIQUIDATE: MaticX, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 32012541745554906519056
LIQUIDATE: MaticX, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 32012541745554906519056
FLASH LOAN: MaticX, Amount: 32012541745554906519056
FLASH LOAN: MaticX, Amount: 32012541745554906519056
E2E: Collateral LINK, TestAsset wstETH
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: wstETH, Amount: 3763155464285060023
WITHDRAW: wstETH, Amount: 1881577732142530011
WITHDRAW: wstETH, Amount: 1881577732142530013
BORROW: wstETH, Amount 3763155464285060023
REPAY: wstETH, Amount: 3763155464285060023
REPAY: wstETH, Amount: 3763155464285060023
BORROW: wstETH, Amount 3763155464285060023
LIQUIDATE: wstETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 3763155464285060023
LIQUIDATE: wstETH, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 3763155464285060023
FLASH LOAN: wstETH, Amount: 3763155464285060023
FLASH LOAN: wstETH, Amount: 3763155464285060023
E2E: Collateral LINK, TestAsset USDC
SUPPLY: LINK, Amount: 6775860103966087091214
SUPPLY: USDC, Amount: 10002950870
WITHDRAW: USDC, Amount: 5001475435
WITHDRAW: USDC, Amount: 5001475435
BORROW: USDC, Amount 10002950870
REPAY: USDC, Amount: 10002950870
REPAY: USDC, Amount: 10002950870
BORROW: USDC, Amount 10002950870
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002950870
LIQUIDATE: USDC, Amount: 115792089237316195423570985008687907853269984665640564039457584007913129639935, Debt Amount: 10002950870
FLASH LOAN: USDC, Amount: 10002950870
FLASH LOAN: USDC, Amount: 10002950870

Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 14.24s (14.08s CPU time)

Ran 1 test suite in 14.25s (14.24s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

@ianflexa ianflexa merged commit 22650a1 into bgd-labs:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TepNik TepNik TepNik approved these changes

@ianflexa ianflexa ianflexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marczeller @TepNik @ianflexa