StataGSM #612
Open
StataGSM #612
+2,184
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/20250114_AaveV3Ethereum_GSMsMigrationToGSM4626/IGsmRegistry.sol
Outdated
Show resolved
Hide resolved
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Outdated
Show resolved
Hide resolved
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Show resolved
Hide resolved
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Outdated
Show resolved
Hide resolved
src/20250114_AaveV3Ethereum_GSMsMigrationToGSM4626/GSMsMigrationToGSM4626.md
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Show resolved
Hide resolved
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Outdated
Show resolved
Hide resolved
| * - Discussion: https://governance.aave.com/t/arfc-deploy-statausdc-and-statausdt-gsms-on-ethereum/20682 | ||
| */ | ||
| contract AaveV3Ethereum_GSMsMigrationToGSM4626_20250114 is IProposalGenericExecutor { | ||
| using SafeERC20 for IERC20; |
There was a problem hiding this comment.
apparently not needed. import neither
There was a problem hiding this comment.
it's used in forceApprove()
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
...4_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.t.sol
Outdated
Show resolved
Hide resolved
Comment on lines
419
to
435
| interface IFeeStrategy { | ||
| function getBuyFee(uint256 grossAmount) external view returns (uint256); | ||
| function getSellFee(uint256 grossAmount) external view returns (uint256); | ||
| } | ||
|
|
||
| interface IOracleSwapFreezer { | ||
| function getCanUnfreeze() external view returns (bool); | ||
| function getFreezeBound() external view returns (uint128, uint128); | ||
| function getUnfreezeBound() external view returns (uint128, uint128); | ||
| function checkUpkeep(bytes calldata) external view returns (bool, bytes memory); | ||
| function performUpkeep(bytes calldata) external; | ||
| } | ||
|
|
||
| interface IFixedPriceStrategy4626 { | ||
| function getAssetPriceInGho(uint256 assetAmount, bool roundUp) external view returns (uint256); | ||
| function getGhoPriceInAsset(uint256 ghoAmount, bool roundUp) external view returns (uint256); | ||
| } |
There was a problem hiding this comment.
should these be moved to src/interfaces?
There was a problem hiding this comment.
i don't think they'll be used too often so didn't want to pollute the interfaces folder
...114_AaveV3Ethereum_GSMsMigrationToGSM4626/AaveV3Ethereum_GSMsMigrationToGSM4626_20250114.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to earn yield on the assets held on the GSM, upgrade from a native token GSM to a stataGSM.
CHANGELOG
Upgrade GSM implementation to new stataGSM and migrate liquidity.
Add tests for GSM functionality and set up.