feat: separate trace logs from normal WAL transmission#18
Draft
feat: separate trace logs from normal WAL transmission#18
Conversation
- Add frame_parser.go for trace/non-trace log separation using byte matching - Add trace_store.go for height-indexed trace file management - Modify agent.go for 2-phase transmission (non-trace first, then trace for failures) - Add trace cleanup loop to manage disk usage
- extractHeight now parses 'height' field from StoreTraceSet JSON - Uses bytes.Index for fast height extraction without JSON unmarshalling - Update cleanup.go for range-based trace files - Add TraceDir config option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement trace log separation. Trace logs are stored locally by cosmos-sdk and only sent when consensus failure occurs.
Background
_msg: "store trace set") record all KV operations, resulting in large data volumeChanges
trace_store.go: Load specific height traces from SDK's range files (trace-{min}-{max}.gz)agent.go: Send/delete traces based onfailure_heightsin ingest responsecleanup.go: Trace file cleanup logic