feat: add MemTraceWriter for file-based trace logging#7
Draft
djm07073 wants to merge 1 commit intov0.53.4-memloggerfrom
Draft
feat: add MemTraceWriter for file-based trace logging#7djm07073 wants to merge 1 commit intov0.53.4-memloggerfrom
djm07073 wants to merge 1 commit intov0.53.4-memloggerfrom
Conversation
Replace the old TraceWriter (which logged to memlogger) with a new
MemTraceWriter that writes trace operations directly to gzipped files
in StoreTraceSet format.
- Output format: trace-{minHeight}-{maxHeight}.gz with bundled
StoreTraceSet JSON per height
- Async compression via background goroutine with 64-item buffered channel
- Files written to {nodeHome}/data/traces/ directory
- Removed auto-enable TraceWriter logic from baseapp/options.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the old
TraceWriter(which logged to memlogger) with a newMemTraceWriterthat writes trace operations directly to gzipped files inStoreTraceSetformat.Reasoning
Notes
trace-{minHeight}-{maxHeight}.gzwith bundledStoreTraceSetJSON per height{nodeHome}/data/traces/directorybaseapp/options.go