Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix: Report aggregation for jacoco #826

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Fix: Report aggregation for jacoco #826

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
228a200
Fix: Report aggregation for jacoco
biswassri Oct 13, 2022
b053797
Merge branch 'main' of github.com:biswassri/kas-fleetshard into jacoc…
biswassri Oct 14, 2022
bbd0431
testing
biswassri Oct 14, 2022
f462edb
Adding output director
biswassri Oct 14, 2022
d50bafa
Removing getter/setter from ProfileCapacity
biswassri Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,19 @@
</excludes>
</configuration>
<executions>
<execution>
<id>default-report</id>
<goals>
<goal>report</goal>
</goals>
</execution>
<execution>
<id>default-report</id>
<phase>verify</phase>
<goals>
<goal>report-aggregate</goal>
</goals>
<configuration>
<includeCurrentProject>true</includeCurrentProject>
<formats>
<format>XML</format>
</formats>
</configuration>
</execution>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sonar.yml job is looking for the jacoco.xml files in target/site/jacoco and report-aggregate puts them in target/site/jacoco-aggregate. You should be able to add <outputDirectory>${project.reporting.outputDirectory}/jacoco</outputDirectory> to override it to the expected location.

Also, just a nit - but this XML block can be indented.

Copy link
Contributor Author

@biswassri biswassri Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes! I missed that change in this commit. But @MikeEdgar one concern/question I have is that
Even with these changes, in the operator index.html we see api and common coverage but not operator coverage. Same for sync. I think we are missing something here. What do you think?

I experimented with report and report-aggregate but had no luck.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is definitely still not right... I'm checking now too.

<execution>
<id>jacoco-check</id>
<goals>
Expand Down