feat: add extra time that prevents from instantly suspending out of quota kafkas #1716
Conversation
| @@ -440,7 +440,7 @@ func (k *KafkaManager) updateExpiresAtBasedOnQuotaEntitlement(kafka *dbapi.Kafka | |||
| } | |||
|
|
|||
| // set expires_at to now + grace period days | |||
There was a problem hiding this comment.
the comment needs to be updated as well?
There was a problem hiding this comment.
yes. I will update it. I also need to add code to remove expiration if quota is now > 0
| @@ -440,7 +440,7 @@ func (k *KafkaManager) updateExpiresAtBasedOnQuotaEntitlement(kafka *dbapi.Kafka | |||
| } | |||
|
|
|||
| // set expires_at to now + grace period days | |||
| expiresAtTime := time.Now().AddDate(0, 0, billingModel.GracePeriodDays) | |||
| expiresAtTime := time.Now().AddDate(0, 0, billingModel.GracePeriodDays).Add(time.Hour * 12) | |||
There was a problem hiding this comment.
Just a question for my understanding: How was the 12 hours period choosen? And how is it different to grace period?
There was a problem hiding this comment.
it was jus an arbitrary number of hours, so kafkas won't be instantly suspended if allowed quota intermittently shows 0
There was a problem hiding this comment.
Thanks for the clarification. Might be good to extract the "magic" number onto a const/variable with a proper name and comment if possible.
There was a problem hiding this comment.
makes sense. will do that
feat: add extra time that prevents from instantly suspending out of quota kafkas
Description
Verification Steps
Checklist (Definition of Done)