-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Program Registries Phase 2 #7231
base: main
Are you sure you want to change the base?
Conversation
* Update programRegistry.stories.jsx * update form stories * refactor program registry fetch * Update forms.stories.jsx * feat(tamanuWeb): SAV-869: Condition category field model (#7196) * add condition category field * remove white space changes * feat(tamanuWeb): SAV-869: Add program registry condition category field (#7189) * Update PatientProgramRegistryForm.jsx * Update PatientInfoPane.jsx * update form data state * data migration * mobile migration * docs * Update patient_program_registration_conditions.md * refactor for usability * Update patient_program_registration_conditions.md * Update PatientProgramRegistration.test.js * clear category on condition clear * remove console log * Update programRegistry.stories.jsx * add missing translations * Update PatientProgramRegistryForm.jsx * fix up queries
Android builds 📱
|
🍹
|
Suspected: 'Suspected', | ||
'Under investigation': 'Under investigation', | ||
Confirmed: 'Confirmed', | ||
Unknown: 'Unknown', | ||
Disproven: 'Disproven', | ||
Resolved: 'Resolved', | ||
'In remission': 'In remission', | ||
'Not applicable': 'Not applicable', | ||
'Recorded in error': 'Recorded in error', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about these keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - as discussed, let's change them to camelCase keys
conditions: [ | ||
{ | ||
conditionId: programRegistryCondition.id, | ||
category: PROGRAM_REGISTRY_CONDITION_CATEGORIES.CONFIRMED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay I see why, this is a POST, we're sending undefined, it probably saves it as 'Unknown'
and we never check for this value later 🤔
* update program view layout * fix query keys * translations * pr fixes * Update PatientProgramRegistryForm.jsx
Epic: Program Registries Phase 2