feat(repeatingAppointments): NASS-1572: Clean up appointments using sync hook #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was behaving more like intialForm values
…ttps://github.com/beyondessential/tamanu into feat/nass-1422-modify-repeating-enable-on-frontend
…clean-up-appointments
rohan-bes
requested changes
Feb 18, 2025
| isFullyGenerated: true, | ||
| untilDate: previousAppointment ? previousAppointment.startTime : appointment.startTime, | ||
| cancelledAtDate: previousAppointment ? previousAppointment.startTime : appointment.startTime, |
There was a problem hiding this comment.
Do we also need to be setting untilDate to this value as well? Otherwise the next time that the GenerateRepeatingAppointments scheduled task runs it might re-generate these?
There was a problem hiding this comment.
Thanks for grabbing this PR. Ohh let me look into this I think you are right
There was a problem hiding this comment.
I decided to keep untilDate as record of intended generation end time. But adding the cancelled_at_date clause and deleted_at as well while I was at it in case of db delete. 🙏
There was a problem hiding this comment.
Ah yep that makes sense! Nice stuff :)
|
Android builds 📱
|
🍹
|
rohan-bes
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
this and all future appointmentsReproduction path
This will mean that repeating appointment will hit limit at second generated appointment - meaning that the task will kick in to generate another two
Generate repeating appointment with occurrence count 4 and weekly frequency (it should create 2 appointments hitting max)
Make sure it has synced once to central and then before the next sync cancel repeating appointment from first appointment into future
After sync ensure there are no appointments that have appeared at week 3 and 4 ( I will check database too )
Deploys
Remember to...