tweak(mobile): Mobile small cleanup 270125 #7145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavarroEmilioLuis
changed the title
NavarroEmilioLuis
force-pushed
the
tweak/no-issue-model-cleanup-270125
branch
from
2bca320 to
ab86760
Compare
…mponent and not any callback
NavarroEmilioLuis
requested review from
edmofro and
chris-bes
as code owners
dannash100
approved these changes
Feb 18, 2025
| @@ -78,7 +78,7 @@ export const AutocompleteModalField = ({ | |||
| setLabel(null); | |||
| } | |||
| })(); | |||
| }, [value]); | |||
| }, [value, refDataType, suggester]); | |||
There was a problem hiding this comment.
Eek some of these ones scare me they have caused issues in past when applying exhaustive deps lint rules to a codebase. I think best to check these ones if possible in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Well this was meant to be a different thing. I was working in some other place and wasn't feeling all the warnings. Plus, I ended up resolving some other lint issues from GitHub.
Deploys