Prepare multinode#1315
Open
geekingfrog wants to merge 3 commits into
Open
Conversation
geekingfrog
force-pushed
the
prepare-multinode
branch
3 times, most recently
from
5fcb96d to
8fc2068
Compare
geekingfrog
force-pushed
the
prepare-multinode
branch
3 times, most recently
from
73d78b4 to
5d127f8
Compare
This is useful when running multiple nodes on the same machine. It is simpler to just disable that instead of setting up different port for all listeners.
geekingfrog
force-pushed
the
prepare-multinode
branch
from
983caf8 to
4895d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I'm looking at multi node support, I realised there are currently some issue with our usage of Horde's supervisors.
Although the API is a drop-in replacement, the processes need to be able to handle conflicts.
When connecting 2 nodes together, some of the "singleton" processes like the client registry, are spawned at startup, and then conflict with the other node's processes.
We can add horde back later when that makes sense, it's a rather small change, but it requires a little bit of consideration when doing so.