Add Map StartPos column type - #2
Open
burnhamrobertp wants to merge 7 commits into
Open
Conversation
Author
burnhamrobertp
force-pushed
the
feature/map-startpos-editor
branch
from
June 30, 2026 05:57
84a760c to
1177e2c
Compare
Collaborator
And there is no undo, if you misclick something, just want to play with the thing, you accidentally modified the data. This is exactly why the startbox editor doesn't do auto save and save is explicit action.
This doesn't show whole map, it's cut startbox editor handles this correctly, in both X and Y coordinates.
This alignment is then also problematic when modifying the map in full screen, map doesn't fill the screen properly:
Being able to zoom-in/zoom-out to be able to place the elements precisely was a requirement and why https://files.p2004a.com/startpos-editor/ has this functionality |
Author
|
The more I got into the UX the more I saw how it could be improved, in addition to the issues you pointed out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Adds a graphical editor for the maps table's startPos column, in the same spirit as the startbox editor. You place and name start positions on the minimap (drag to move, click a marker to rename / set coords / delete), and per team configuration assign each spawn to a team with a role and optional base center. Configs (1v1, 4v4, 8v8, ...) are read from the data and you can add or remove them. Markers approximate the in-game start circles (radius and label sizes taken from map_start_position_suggestions.lua), and there's a raw-JSON view in the editor for copy/paste. Edits auto-save.
It's a single column that should work as an in-place replacement for the JSON column presently in place. It uses some of the same configurability as what the startboxes column has but didn't require a subtable, since a startPos value is one document with shared named positions that every config references. The stored value stays a Firestore map - the same shape as the current JSON column - so update_from_rowy reads it unchanged.
Assisted by Claude Opus 4.8