[macOS] Add macOS BAR.app runtime stack#606
Closed
yeojuny wants to merge 5 commits into
Closed
Conversation
This was referenced Jun 24, 2026
9fc5e44 to
55f7cd5
Compare
Collaborator
|
This PR will not be merged nor considered as presented and it doesn't make sense it stays open in the review queue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a draft PR for the BAR.app macOS runtime stack in bar-lobby.
It adds the lobby-side pieces for launching the native macOS engine from the app bundle:
Why
The accepted Apple Silicon user path is BAR.app through bar-lobby. This PR makes the lobby own the native-engine handoff instead of relying on ad-hoc direct-engine scripts or local machine state.
Validation
Initial branch validation before rebasing onto the latest upstream master:
git diff HEAD^..HEAD --checknpm run typecheck:nodenpm run typecheck:webnpx vitest run tests/unit/main/native-engine-runner.spec.ts tests/unit/main/content-sources.spec.ts tests/unit/main/auto-updater.spec.ts tests/unit/main/start-script-converter.spec.ts tests/unit/shared/preload-api-context-bridge.spec.tsAfter rebasing onto upstream
a444fb4:git diff origin/master...HEAD --checknpm run typecheck:nodenpx vitest run tests/unit/main/native-engine-runner.spec.ts tests/unit/main/content-sources.spec.ts tests/unit/main/auto-updater.spec.ts tests/unit/main/start-script-converter.spec.ts tests/unit/shared/preload-api-context-bridge.spec.tsAfter CI follow-up fixes on this head:
git diff --checknpx prettier --experimental-cli --check docs/macos-homebrew-runtime-packaging.md tests/unit/main/main-process-lifecycle.spec.tsnpx prettier --experimental-cli --check src/main/config/native-engine-runner.ts tests/unit/main/native-engine-runner.spec.tsnpx vitest run tests/unit/main/main-process-lifecycle.spec.tsnpx vitest run tests/unit/main/native-engine-runner.spec.tsnpm run typecheck:nodenpm run test(8 files, 58 tests)Current
npm run typecheck:webon the rebased branch reports an upstream-existing error in unchangedsrc/renderer/store/party.store.ts(PartyCreateOkResponseData.partyvspartyId). This file has no diff in this PR.Clean-machine path
See
docs/macos-clean-machine-validation.md. The checklist defines the fresh-checkout build, bundled-assets input shape, static bundle checks, BAR.app runtime smoke signals, and failure ownership boundaries.Related draft PRs
Notes for reviewers
This is draft because public distribution still needs clean-machine runtime closure, state scrubbing, signing/notarization/quarantine handling, and reproducible release packaging. Generated bundle files and local BAR-data state are intentionally not included.