Skip to content

Override extension for replay files - #584

Merged
Hectate merged 2 commits into
beyond-all-reason:masterfrom
BElluu:issue-538-20260525
Aug 4, 2026
Merged

Override extension for replay files#584
Hectate merged 2 commits into
beyond-all-reason:masterfrom
BElluu:issue-538-20260525

Conversation

@BElluu

@BElluu BElluu commented May 25, 2026

Copy link
Copy Markdown
Contributor

Closed #538

Waiting for changes from:

  1. Set correct springsettings for engine #578
  2. RecoilEngine #2975
    Changes in engine merged

@BElluu
BElluu marked this pull request as ready for review August 2, 2026 10:40
@Hectate
Hectate self-requested a review August 2, 2026 21:35
@Hectate

Hectate commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Per the electron-builder documentation, we need perMachine to be true to associate files on Windows. I thought we had that already, though, which is why that seems odd to me. I could be wrong.

I presume I can just rename a normal replay to have the new extension to test? That is to say; internally there is no difference in the replays, it's only the extension that has changed?

@BElluu

BElluu commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Yea that's only extension name. You can change extension for any replay and test it.

@Hectate

Hectate commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This seems good. The replays won't start using the new extension until the next engine release, I presume, but that's not going to stop the existing ones from working and it'll automatically pick up the new replays once they start being made. Thanks.

@Hectate
Hectate merged commit 0261578 into beyond-all-reason:master Aug 4, 2026
3 checks passed
@BElluu
BElluu deleted the issue-538-20260525 branch August 5, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up file association for replay files

2 participants