Override extension for replay files - #584
Merged
Merged
Conversation
BElluu
marked this pull request as ready for review
August 2, 2026 10:40
Hectate
self-requested a review
August 2, 2026 21:35
Contributor
|
Per the electron-builder documentation, we need I presume I can just rename a normal replay to have the new extension to test? That is to say; internally there is no difference in the replays, it's only the extension that has changed? |
Contributor
Author
|
Yea that's only extension name. You can change extension for any replay and test it. |
Hectate
approved these changes
Aug 4, 2026
Contributor
|
This seems good. The replays won't start using the new extension until the next engine release, I presume, but that's not going to stop the existing ones from working and it'll automatically pick up the new replays once they start being made. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #538
Waiting for changes from:
Changes in engine merged