Fix npm deprecation warnings and reduce vulnerabilities#550
Open
mfeeney wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi, I've merged a bunch of dependatbots PR. If you can check the conflict on package-lock :) |
…reason#512) Replace glob-promise with modern glob@11 which has native Promise support, eliminating the transitive dependency on deprecated glob@8 and inflight. Use minimatch directly for pattern matching in parseSdpFile instead of going through the Glob class. Bump electron-forge, electron-builder, and electron-updater to latest minor versions to pick up transitive dependency fixes. Relax the Node engine constraint from exact 22.18.0 to >=22.16.0 so contributors on different patch releases don't get EBADENGINE warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mfeeney
force-pushed
the
fix/npm-deprecation-warnings-512
branch
from
February 20, 2026 16:25
c115b2f to
78153e5
Compare
Author
|
Rebased on latest master and regenerated the lock file, should be good now! :) |
p2004a
reviewed
Feb 21, 2026
p2004a
left a comment
p2004a
left a comment
Collaborator
There was a problem hiding this comment.
sorry about it but it needs to be rebased again
| import * as fs from "fs"; | ||
| import * as glob from "glob-promise"; | ||
| import { glob } from "glob"; | ||
| import { Minimatch } from "minimatch"; |
Collaborator
There was a problem hiding this comment.
there should be direct dependency in package.json if we use this library directly
Contributor
There was a problem hiding this comment.
@mfeeney Did you want to add Minimatch to the package.json so this can be looked at for a merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #512. Cleans up what we can on the deprecation/vulnerability front without major version bumps.
glob-promisewithglob@11—glob-promisewas our only actionable direct dependency here. It wraps the deprecatedglob@8, which drags ininflight(known memory leak, deprecated). Modern glob has native Promise support so the wrapper isn't needed anymore. Usedminimatchdirectly for the pattern-matching inparseSdpFilesince that's all the oldGlobclass was being used for there.22.18.0to>=22.16.0— contributors on any recent Node 22 release won't getEBADENGINEwarnings anymore. CI still pins 22.18.0 explicitly so builds are deterministic.npm audit fixfor any remaining safe automatic fixes.Why most warnings/vulns remain
The bulk of the deprecation warnings and audit findings come from deep transitive dependencies in electron-builder, electron-forge, eslint, and related build tooling — things like old versions of
glob,rimraf,minimatch,tar,tmp, etc. that are baked into those packages' dependency trees. We can't fix those without major version bumps (e.g. electron 37→40, primevue 3→4, eslint ecosystem changes), which are separate efforts and out of scope here.Test plan
npm run typecheckpassesnpx eslint .cleannpx vitest run tests— 28/28 passnpm start— app launches and runs normally