macOS: add CpuTopology + SoLib to engine threading sources#3044
Open
tomjn wants to merge 1 commit into
Open
Conversation
The engine threading source list for macOS (sources_engine_System_Threading_Mac)
provided only Signal.cpp, while the Linux list also supplies CpuTopology
and SoLib. Building spring-dedicated on macOS therefore failed to link:
Undefined symbols for architecture arm64:
cpu_topology::GetProcessorCache() / GetProcessorMasks() / GetThreadPinPolicy()
SoLib::SoLib(char const*) / SoLib::LoadFailed()
Add Platform/Mac/CpuTopology.cpp (the macOS cpu_topology implementation)
and Platform/Linux/SoLib.cpp (dlopen-based, portable to macOS) to the Mac
threading sources, mirroring the Linux list.
Mac-only list; no effect on Linux/Windows.
sprunk
approved these changes
Jun 22, 2026
sprunk
requested changes
Jun 22, 2026
sprunk
left a comment
sprunk
left a comment
Collaborator
There was a problem hiding this comment.
Actually there is no CpuTopology.cpp yet so this depends on some other PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Platform/Mac/CpuTopology.cppandPlatform/Linux/SoLib.cpptosources_engine_System_Threading_Mac.The macOS threading source list provided only
Signal.cpp, whereas the Linux equivalent (sources_engine_System_Threading_Linux) also suppliesCpuTopologyandSoLib. Building spring-dedicated on macOS therefore failed at link:Platform/Mac/CpuTopology.cpp— the macOScpu_topologyimplementation (added in the unitsync-build PR; this wires it into the engine threading sources too).Platform/Linux/SoLib.cpp—dlopen-based shared-library loader; portable and used as-is on macOS (the Linux list groups it under threading).Notes
spring-dedicatedbuilds and runs as a native arm64 binary under Homebrew GCC — verified locally.sources_engine_System_Threading_Macblock as the ThreadSupport PR (macOS: add ThreadSupport (no-op suspend/resume) #3036); whichever merges second needs a trivial context rebase.