Enable TCPAllowConnect option#1084
Draft
AntlerForce wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a
springsettings.cfgoption in Recoil calledTCPAllowConnectthat is not set by BAR. This is why LuaSocket connections from anywhere are currently permitted. If we want to block unauthorized luasocket connections we need to add the following to config:TCPAllowConnect = 127.0.0.1:-1 server4.beyondallreason.info:8200We need to allow
127.0.0.1:-1because spring-launcher connects to loopback with a new port each time, this appears in infolog like so:This PR uncomments the
dumpConfigfunction to perceive current luasocket restrictions in log. If done correctly, they will appear like this:This PR does not enforce this config for everyone, as it is read-only from lua and according to spring documentation, can only be set from unitsync. So it remains as draft until that is figured out.
https://springrts.com/wiki/Lua_Socket