Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33
this should not merged until bevy 0.11.1 is out. builds on @VitalyAnkh's partial migration, with additionally :
Rc<RefCell>
forconst_expressions
andconst_expr_map
- this is basically unavoidable, asDerivedModule::import_expression
needs access to both theconst_expressions
and the arena to import into, which may also beconst_expressions
Expression::Literal
andExpression::ZeroValue
sconst_expression
uniqueness with a custom impl ofPartialEq
forExpression
s, to ensure that the uniqueness test for globals and consts still passes (else we end up with duplicated items, they no longer test as equal as they refer to differentinit
expressions). this could be removed if thePartialEq
derive onExpression
in naga is made externally available.prune
module which just leaves allconst_expressions
presentthe tests pass, but i haven't tried integrating into bevy (which will require bevy to use wgpu 0.17).