update to OpenRefine 3.1 and some basic enhancements by psychemedia #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for refurbishing this! |
betatim
reviewed
Jul 25, 2019
| @@ -33,6 +36,6 @@ def get(self, *args): | |||
| def setup_handlers(web_app): | |||
| web_app.add_handlers('.*', [ | |||
| (ujoin(web_app.settings['base_url'], 'openrefine/(.*)'), | |||
| OpenRefineProxyHandler, dict(state={})), | |||
| OpenRefineProxyHandler, dict(state={'port':3333})), | |||
There was a problem hiding this comment.
What is the advantage of doing this?
There was a problem hiding this comment.
Thanks for merging!
3333 is the default port used by OpenRefine. Specifying it here makes it easier to connect with the python client (which tries to reach the OpenRefine server on 127.0.0.1:3333 by default). @psychemedia suggested this in #6 (comment)
|
I'll merge this now and if we need to we can make a new PR to change the port behaviour again. |
This was referenced Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to suggest some improvements from @psychemedia (and some minor additions by myself) for the main repo:
There is also a demo notebook in https://github.com/ouseful-PR/openrefineder. It works with the suggested changes in this pull request but I think that it is still work in progress.