-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "js: introduce the Biome linter/formatter (#20754)"" #20765
Conversation
Pour moi la recherche est toujours pétée, on ne peut pas combiner les filtres. |
OK genre quoi ? moi ça a l'air de fonctionner mais je la comprend moins bien je crois |
It's a case of for..in vs for..of which is my mistake, sorry.
Avoid mutating the parameter – which is why I broke it in the first place by using a new variable that was being overwritten on each filter instead of being successively filtered. Go for a functional approach where these filters are combined or shortcut if necessary.
17a4116
to
d4aa0ef
Compare
Et le reste du JS.... mériterait un petit nettoyage mais bon il y a p-e une approche un peu plus globale à revoir |
Effectivement, apparemment c'était utilisé sur feu la page Brigade
doux euphémisme |
Cela dit c'est un peu le but de la PR – rafistoler le JS au moins sur l'esthétique (quand je fais pas des fix à la va vite par dessus) – pour faciliter le nettoyage, refactor, entretien, etc |
Reverts #20763 and fix the search bug associated I introduced: 8160f5b