Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace popper with fork #508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace popper with fork #508

wants to merge 1 commit into from

Conversation

bestguy
Copy link
Owner

@bestguy bestguy commented Oct 4, 2022

Removes process.env crap

@bestguy
fix - replace popper with fork
5b7475e 
Removes process.env crap
@mattkanwisher
Copy link

this going to be merged soon? this project isn't useable in its current state

@dysfunc dysfunc added Priority: Medium Bug, issue, or pull request is a P2 Type: Refactor Enhancements, deletions, etc. to existing code labels Nov 12, 2022
@benmccann
Copy link
Contributor

This PR can be closed. Sveltestrap was updated to use the latest version of popper which no longer uses process.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Medium Bug, issue, or pull request is a P2 Type: Refactor Enhancements, deletions, etc. to existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bestguy @mattkanwisher @benmccann @dysfunc