chore: Update dependencies

.eslintrc

@@ -1,5 +1,6 @@
 {
-  "extends": [
-    "standard"
-  ]
+  "extends": ["prettier-standard"],
+  "rules": {
+    "lines-between-class-members": "off"
+  }
 }

.prettierrc

@@ -0,0 +1 @@
+"prettier-config-standard"

README.md

@@ -34,7 +34,7 @@ yarn lerna add fs-extra --scope=puppeteer-extra-plugin-user-data-dir
 
 # Remove dependency
 # https://github.com/lerna/lerna/issues/833
-yarn lerna exec -- yarn remove fs-extra
+yarn lerna exec 'yarn remove fs-extra; echo 0'
 
 # Run test in all packages
 yarn test
@@ -51,4 +51,8 @@ yarn lerna bootstrap
 
 # Update deps within packages (interactive)
 yarn lernaupdate
+
+# If in doubt :-(
+yarn lerna exec "rm -f yarn.lock; rm -rf node_modules; echo 0"
+rm -f yarn.lock &&  rm -rf node_modules && yarn cache clean
 ```

lerna.json

@@ -1,8 +1,5 @@
 {
-  "lerna": "2.11.0",
-  "packages": [
-    "packages/*"
-  ],
+  "packages": ["packages/*"],
   "version": "independent",
   "useWorkspaces": true,
   "npmClient": "yarn",

package.json

@@ -20,11 +20,22 @@
     "packages/*"
   ],
   "devDependencies": {
+    "eslint": "^6.7.0",
+    "eslint-config-prettier": "^6.7.0",
+    "eslint-config-prettier-standard": "^3.0.1",
+    "eslint-config-standard": "^14.1.0",
+    "eslint-plugin-import": "^2.18.2",
+    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-prettier": "^3.1.1",
+    "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-standard": "^4.0.1",
     "lerna": "^3.19.0",
-    "lerna-update-wizard": "^0.17.4"
+    "lerna-update-wizard": "^0.17.4",
+    "prettier": "^1.19.1",
+    "prettier-config-standard": "^1.0.1"
   },
   "resolutions": {
-    "**/fsevents": "^1.2.9"
+    "**/fsevents": "^2.1.2"
   },
   "dependencies": {}
 }

packages/puppeteer-extra-plugin-anonymize-ua/index.js

@@ -22,23 +22,23 @@ const { PuppeteerExtraPlugin } = require('puppeteer-extra-plugin')
  * const browser = await puppeteer.launch()
  */
 class Plugin extends PuppeteerExtraPlugin {
-  constructor (opts = {}) {
+  constructor(opts = {}) {
     super(opts)
   }
 
-  get name () {
+  get name() {
     return 'anonymize-ua'
   }
 
-  get defaults () {
+  get defaults() {
     return {
       stripHeadless: true,
       makeWindows: true,
       customFn: null
     }
   }
 
-  async onPageCreated (page) {
+  async onPageCreated(page) {
     let ua = await page.browser().userAgent()
     if (this.opts.stripHeadless) {
       ua = ua.replace('HeadlessChrome/', 'Chrome/')
@@ -54,6 +54,6 @@ class Plugin extends PuppeteerExtraPlugin {
   }
 }
 
-module.exports = function (pluginConfig) {
+module.exports = function(pluginConfig) {
   return new Plugin(pluginConfig)
 }

packages/puppeteer-extra-plugin-anonymize-ua/index.test.js

@@ -2,22 +2,22 @@
 
 const PLUGIN_NAME = 'anonymize-ua'
 
-const { test } = require('ava')
+const test = require('ava')
 
 const Plugin = require('.')
 
-test('is a function', async (t) => {
+test('is a function', async t => {
   t.is(typeof Plugin, 'function')
 })
 
-test('should have the basic class members', async (t) => {
+test('should have the basic class members', async t => {
   const instance = new Plugin()
 
   t.is(instance.name, PLUGIN_NAME)
   t.true(instance._isPuppeteerExtraPlugin)
 })
 
-test('should have the public child class members', async (t) => {
+test('should have the public child class members', async t => {
   const instance = new Plugin()
   const prototype = Object.getPrototypeOf(instance)
   const childClassMembers = Object.getOwnPropertyNames(prototype)
@@ -29,7 +29,7 @@ test('should have the public child class members', async (t) => {
   t.true(childClassMembers.length === 4)
 })
 
-test('should have opts with default values', async (t) => {
+test('should have opts with default values', async t => {
   const instance = new Plugin()
   const opts = instance.opts
 

packages/puppeteer-extra-plugin-anonymize-ua/package.json

@@ -8,7 +8,7 @@
   "license": "MIT",
   "scripts": {
     "docs": "update-markdown-jsdoc",
-    "test": "ava -v && standard",
+    "test": "ava -v && eslint --ext .js .",
     "test-ci": "yarn test"
   },
   "engines": {
@@ -25,13 +25,12 @@
     "pupeteer"
   ],
   "devDependencies": {
-    "ava": "^0.25.0",
-    "puppeteer": "next",
-    "standard": "^11.0.0",
+    "ava": "~2.4.0",
+    "puppeteer": "^2.0.0",
     "update-markdown-jsdoc": "^1.0.2"
   },
   "dependencies": {
-    "debug": "^3.1.0",
+    "debug": "^4.1.1",
     "puppeteer-extra-plugin": "^3.0.4"
   },
   "gitHead": "72fe830c158f1e971c8499fdd5232338dd53c220"

packages/puppeteer-extra-plugin-anonymize-ua/test/headless.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { test } = require('ava')
+const test = require('ava')
 
 const PUPPETEER_ARGS = ['--no-sandbox', '--disable-setuid-sandbox']
 
@@ -10,13 +10,16 @@ test.beforeEach(t => {
   delete require.cache[require.resolve('puppeteer-extra-plugin-anonymize-ua')]
 })
 
-test('will remove headless from the user-agent', async (t) => {
+test('will remove headless from the user-agent', async t => {
   const puppeteer = require('puppeteer-extra')
-  puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
+  const AnonymizeUA = require('puppeteer-extra-plugin-anonymize-ua')()
+  puppeteer.use(AnonymizeUA)
 
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
   const page = await browser.newPage()
-  await page.goto('https://httpbin.org/headers', {waitUntil: 'domcontentloaded'})
+  await page.goto('https://httpbin.org/headers', {
+    waitUntil: 'domcontentloaded'
+  })
 
   const content = await page.content()
   t.true(content.includes('Windows NT 10.0'))
@@ -26,7 +29,7 @@ test('will remove headless from the user-agent', async (t) => {
   t.true(true)
 })
 
-test('will remove headless from the user-agent in incognito page', async (t) => {
+test('will remove headless from the user-agent in incognito page', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
 
@@ -36,7 +39,9 @@ test('will remove headless from the user-agent in incognito page', async (t) =>
   if (browser.createIncognitoBrowserContext) {
     const context = await browser.createIncognitoBrowserContext()
     const page = await context.newPage()
-    await page.goto('https://httpbin.org/headers', {waitUntil: 'domcontentloaded'})
+    await page.goto('https://httpbin.org/headers', {
+      waitUntil: 'domcontentloaded'
+    })
 
     const content = await page.content()
     t.true(content.includes('Windows NT 10.0'))
@@ -47,15 +52,19 @@ test('will remove headless from the user-agent in incognito page', async (t) =>
   t.true(true)
 })
 
-test('will use a custom fn to modify the user-agent', async (t) => {
+test('will use a custom fn to modify the user-agent', async t => {
   const puppeteer = require('puppeteer-extra')
-  puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')({
-    customFn: (ua) => 'MyCoolAgent/' + ua.replace('Chrome', 'Beer')
-  }))
+  puppeteer.use(
+    require('puppeteer-extra-plugin-anonymize-ua')({
+      customFn: ua => 'MyCoolAgent/' + ua.replace('Chrome', 'Beer')
+    })
+  )
 
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
   const page = await browser.newPage()
-  await page.goto('https://httpbin.org/headers', {waitUntil: 'domcontentloaded'})
+  await page.goto('https://httpbin.org/headers', {
+    waitUntil: 'domcontentloaded'
+  })
 
   const content = await page.content()
   t.true(content.includes('Windows NT 10.0'))
@@ -66,24 +75,3 @@ test('will use a custom fn to modify the user-agent', async (t) => {
   await browser.close()
   t.true(true)
 })
-
-test('will not modify the user-agent when disabled', async (t) => {
-  const puppeteer = require('puppeteer-extra')
-  puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')({
-    stripHeadless: false,
-    makeWindows: false,
-    customFn: null
-  }))
-
-  const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
-  const page = await browser.newPage()
-  await page.goto('https://httpbin.org/headers', {waitUntil: 'domcontentloaded'})
-
-  const content = await page.content()
-  t.true(content.includes('HeadlessChrome'))
-  t.true(!content.includes('MyCoolAgent/Mozilla'))
-  t.true(!content.includes('Beer/'))
-
-  await browser.close()
-  t.true(true)
-})

packages/puppeteer-extra-plugin-anonymize-ua/test/headless_off.js

@@ -0,0 +1,35 @@
+'use strict'
+
+const test = require('ava')
+
+const PUPPETEER_ARGS = ['--no-sandbox', '--disable-setuid-sandbox']
+
+test.beforeEach(t => {
+  // Make sure we work with pristine modules
+  delete require.cache[require.resolve('puppeteer-extra')]
+  delete require.cache[require.resolve('puppeteer-extra-plugin-anonymize-ua')]
+})
+
+test('will not modify the user-agent when disabled', async t => {
+  const puppeteer = require('puppeteer-extra')
+  const AnonymizeUA = require('puppeteer-extra-plugin-anonymize-ua')({
+    stripHeadless: false,
+    makeWindows: false,
+    customFn: null
+  })
+  puppeteer.use(AnonymizeUA)
+
+  const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
+  const page = await browser.newPage()
+  await page.goto('https://httpbin.org/headers', {
+    waitUntil: 'domcontentloaded'
+  })
+
+  const content = await page.content()
+  t.true(content.includes('HeadlessChrome'))
+  t.true(!content.includes('MyCoolAgent/Mozilla'))
+  t.true(!content.includes('Beer/'))
+
+  await browser.close()
+  t.true(true)
+})

packages/puppeteer-extra-plugin-anonymize-ua/test/popup.js

@@ -1,10 +1,10 @@
 'use strict'
 
-const { test } = require('ava')
+const test = require('ava')
 
 const PUPPETEER_ARGS = ['--no-sandbox', '--disable-setuid-sandbox']
 
-const waitEvent = function (emitter, eventName) {
+const waitEvent = function(emitter, eventName) {
   return new Promise(resolve => emitter.once(eventName, resolve))
 }
 
@@ -14,14 +14,12 @@ test.beforeEach(t => {
   delete require.cache[require.resolve('puppeteer-extra-plugin-anonymize-ua')]
 })
 
-test('known issue: will not remove headless from implicitly created popup pages', async (t) => {
+test('known issue: will not remove headless from implicitly created popup pages', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
 
-  const pages = await Promise.all(
-    [...Array(10)].map(slot => browser.newPage())
-  )
+  const pages = await Promise.all([...Array(10)].map(slot => browser.newPage()))
   for (const page of pages) {
     // Works
     const ua = await page.evaluate(() => window.navigator.userAgent)

packages/puppeteer-extra-plugin-anonymize-ua/test/stresstest.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { test } = require('ava')
+const test = require('ava')
 
 const PUPPETEER_ARGS = ['--no-sandbox', '--disable-setuid-sandbox']
 
@@ -10,7 +10,7 @@ test.beforeEach(t => {
   delete require.cache[require.resolve('puppeteer-extra-plugin-anonymize-ua')]
 })
 
-test('will remove headless from the user-agent on multiple browsers', async (t) => {
+test('will remove headless from the user-agent on multiple browsers', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
@@ -29,14 +29,12 @@ test('will remove headless from the user-agent on multiple browsers', async (t)
   t.true(true)
 })
 
-test('will remove headless from the user-agent on many pages', async (t) => {
+test('will remove headless from the user-agent on many pages', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
 
-  const pages = await Promise.all(
-    [...Array(30)].map(slot => browser.newPage())
-  )
+  const pages = await Promise.all([...Array(30)].map(slot => browser.newPage()))
   for (const page of pages) {
     const ua = await page.evaluate(() => window.navigator.userAgent)
     t.true(ua.includes('Windows NT 10.0'))
@@ -47,7 +45,7 @@ test('will remove headless from the user-agent on many pages', async (t) => {
   t.true(true)
 })
 
-test('will remove headless from the user-agent on many incognito pages', async (t) => {
+test('will remove headless from the user-agent on many incognito pages', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
@@ -69,7 +67,7 @@ test('will remove headless from the user-agent on many incognito pages', async (
   t.true(true)
 })
 
-test('will remove headless from the user-agent on many pages in parallel', async (t) => {
+test('will remove headless from the user-agent on many pages in parallel', async t => {
   const puppeteer = require('puppeteer-extra')
   puppeteer.use(require('puppeteer-extra-plugin-anonymize-ua')())
   const browser = await puppeteer.launch({ args: PUPPETEER_ARGS })
@@ -80,9 +78,7 @@ test('will remove headless from the user-agent on many pages in parallel', async
     t.true(ua.includes('Windows NT 10.0'))
     t.true(!ua.includes('HeadlessChrome'))
   }
-  await Promise.all(
-    [...Array(30)].map(slot => testCase())
-  )
+  await Promise.all([...Array(30)].map(slot => testCase()))
 
   await browser.close()
   t.true(true)