Skip to content

[upstream #17033] 17033: MCP OAuth teardown hides provider revocation failures #369

Open

Description

@berry-13

Found while reviewing LibreChat-AI#17033 (Codex finding LibreChat-AI#17033 (comment)). cleanupMCPServerOAuth (packages/api/src/mcp/oauth/cleanup.ts) catches provider revocation failures for access and refresh tokens, logs them and clears local state, so neither the server-delete route nor account erasure learns that an external grant stayed valid. The same best-effort revocation runs on dev. Add a strict mode that clears local state and then rejects, and use it where the server record is the only retry anchor.

Activity

  1. added
    bugSomething isn't working
    readyreviewctl followups state
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: packagesreviewctl followups statebugSomething isn't workingreadyreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions