Skip to content

[upstream #17033] 17033: MCP server deletion does not fence viewers without an OAuth token #364

Open

Description

@berry-13

Found while reviewing LibreChat-AI#17033 (Codex finding LibreChat-AI#17033 (comment)). cleanupDeletedMCPServerOAuthUsers (packages/api/src/mcp/oauth/cleanup.ts) takes its candidate users from OAuth token holders only and uses the view-ACL snapshot just to filter them. A viewer of a shared database MCP server with no personal OAuth token (server-level credentials) is never fenced or disconnected when the server is deleted, so an already-loaded tool can keep working. The deleteMCPServerController route in api/server/controllers/mcp.js behaves the same way on dev, and account erasure now shares that protocol. Enumerate direct user ACL principals and group members from the snapshot as candidates.

Activity

  1. added
    bugSomething isn't working
    readyreviewctl followups state
    area: apireviewctl followups state
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: apireviewctl followups statearea: packagesreviewctl followups statebugSomething isn't workingreadyreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions