Skip to content

Commit

Permalink
chore: update base images & disable poetry cache
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlougheed committed Dec 5, 2023
1 parent 838c710 commit c704d1a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2023.11.10
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2023.12.01

# Use uvicorn (instead of hypercorn) in production since I've found
# multiple benchmarks showing it to be faster - David L
Expand All @@ -13,7 +13,7 @@ COPY poetry.lock .
# Without --no-root, we get errors related to the code not being copied in yet.
# But we don't want the code here, otherwise Docker cache doesn't work well.
RUN poetry config virtualenvs.create false && \
poetry install --without dev --no-root
poetry --no-cache install --without dev --no-root

# Manually copy only what's relevant
# (Don't use .dockerignore, which allows us to have development containers too)
Expand Down
4 changes: 2 additions & 2 deletions dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2023.11.10
FROM ghcr.io/bento-platform/bento_base_image:python-debian-2023.12.01

# FastAPI uses uvicorn for a development server as well
RUN pip install --upgrade pip && pip install --no-cache-dir "uvicorn[standard]==0.24.0"
Expand All @@ -13,7 +13,7 @@ COPY run.dev.bash .
# Without --no-root, we get errors related to the code not being copied in yet.
# But we don't want the code here, otherwise Docker cache doesn't work well.
RUN poetry config virtualenvs.create false && \
poetry install --no-root
poetry --no-cache install --no-root

# Tell the service that we're running a local development container
ENV BENTO_CONTAINER_LOCAL=true
Expand Down

0 comments on commit c704d1a

Please sign in to comment.