Skip to content

Add 2024-25 SNOMED CT data#140

Merged
kayleepn merged 3 commits intomainfrom
kayleepn/add-fy2425-data
Nov 18, 2025
Merged

Add 2024-25 SNOMED CT data#140
kayleepn merged 3 commits intomainfrom
kayleepn/add-fy2425-data

Conversation

@kayleepn
Copy link
Copy Markdown
Contributor

Closes #136

Number of codes with multiple descriptions decreased by 1 after adding new data - not sure if this is normal.

Closes #136
@kayleepn
Copy link
Copy Markdown
Contributor Author

# Check (but dont fix) codes with multiple descriptions
codes_with_multiple_desc <- opencodecounts:::get_codes_with_multiple_desc(
icd10_usage,
icd10_code
)
length(codes_with_multiple_desc)
# [1] 214

The number of codes with multiple descriptions went from 214 to 213 after adding 2024-25 FY data

Copy link
Copy Markdown
Collaborator

@milanwiedemann milanwiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great 🚀

@milanwiedemann
Copy link
Copy Markdown
Collaborator

@kayleepn I explored this a bit further, it looks like even when removing the new year from the data, codes with multiple descriptions were 213 (same as after the addition of 2024-25), and the codes appear to be identical identical(old_multiple_desc, new_multiple_desc).

Although the underlying data might have changed, I think it is far more likely that I made a mistake last time I wrote down the count for codes with multiple descriptions here, so I suggest we just move on and merge without further investigation.

> library(tidyverse)
> library(opencodecounts)
> icd10_usage_old <- icd10_usage |> filter(start_date < "2024-04-01")
> icd10_usage_new <- icd10_usage
> old_multiple_desc <- opencodecounts:::get_codes_with_multiple_desc(
+   icd10_usage_old,
+   icd10_code
+ )
> length(old_multiple_desc)
[1] 213
> new_multiple_desc <- opencodecounts:::get_codes_with_multiple_desc(
+   icd10_usage_new,
+   icd10_code
+ )
> length(new_multiple_desc)
[1] 213
> identical(old_multiple_desc, new_multiple_desc)
[1] TRUE

@kayleepn kayleepn merged commit 09cdc90 into main Nov 18, 2025
6 checks passed
@kayleepn kayleepn deleted the kayleepn/add-fy2425-data branch November 18, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add data for NHS FY 2024/25

2 participants