Skip to content

Commit

Permalink
deps: down grade remark
Browse files Browse the repository at this point in the history
  • Loading branch information
benjycui committed Jun 12, 2017
1 parent b0fc36e commit ff091a0
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 24 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
"license": "MIT",
"dependencies": {
"jsonml.js": "^0.1.0",
"remark": "^7.0.1",
"remark": "^5.0.1",
"yaml-front-matter": "^3.4.0"
},
"devDependencies": {
"eslint": "^2.7.0",
"eslint-config-egg": "^2.0.0",
"eslint": "^3.0.0",
"eslint-config-egg": "^4.2.0",
"mocha": "^3.4.2"
}
}
2 changes: 1 addition & 1 deletion src/MT.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const remark = require('remark');
const remark = require('remark')();
const YFM = require('yaml-front-matter');
const transformer = require('./transformer');

Expand Down
38 changes: 19 additions & 19 deletions src/transformer.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,24 @@ function transformer(node) {
transformer(node.children);
switch (node.type) {
case 'root':
return ['article'].concat(transformedChildren);
return [ 'article' ].concat(transformedChildren);
case 'heading':
return [`h${node.depth}`].concat(transformedChildren);
return [ `h${node.depth}` ].concat(transformedChildren);
case 'text':
return node.value;
case 'list':
return [node.ordered ? 'ol' : 'ul'].concat(transformedChildren);
return [ node.ordered ? 'ol' : 'ul' ].concat(transformedChildren);
case 'listItem':
return ['li'].concat(transformedChildren);
return [ 'li' ].concat(transformedChildren);
case 'paragraph':
return ['p'].concat(transformedChildren);
return [ 'p' ].concat(transformedChildren);
case 'link':
return ['a', {
return [ 'a', {
title: node.title,
href: node.url,
}].concat(transformedChildren);
case 'image':
return ['img', {
return [ 'img', {
title: node.title,
src: node.url,
alt: node.alt,
Expand All @@ -47,31 +47,31 @@ function transformer(node) {
isTHead = true;
return [
'table',
['thead', transformTHead(node.children[0])],
['tbody'].concat(transformedChildren),
[ 'thead', transformTHead(node.children[0]) ],
[ 'tbody' ].concat(transformedChildren),
];
case 'tableRow':
return ['tr'].concat(transformedChildren);
return [ 'tr' ].concat(transformedChildren);
case 'tableCell':
return [isTHead ? 'th' : 'td'].concat(transformedChildren);
return [ isTHead ? 'th' : 'td' ].concat(transformedChildren);
case 'emphasis':
return ['em'].concat(transformedChildren);
return [ 'em' ].concat(transformedChildren);
case 'strong':
return ['strong'].concat(transformedChildren);
return [ 'strong' ].concat(transformedChildren);
case 'inlineCode':
return ['code', node.value];
return [ 'code', node.value ];
case 'code':
return ['pre', { lang: node.lang }, ['code', node.value]];
return [ 'pre', { lang: node.lang }, [ 'code', node.value ]];
case 'blockquote':
return ['blockquote'].concat(transformedChildren);
return [ 'blockquote' ].concat(transformedChildren);
case 'break':
return ['br'];
return [ 'br' ];
case 'thematicBreak':
return ['hr'];
return [ 'hr' ];
case 'html':
return JsonML.fromHTMLText(node.value);
case 'linkReference':
return ['span'].concat(transformedChildren);
return [ 'span' ].concat(transformedChildren);
default:
return node;
}
Expand Down
5 changes: 4 additions & 1 deletion test/test.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,7 @@ console.log('Hello world!');

<br />

[LINK REFERENCE]
[LINK REFERENCE]

<img class="preview-img no-padding good" align="right" src="https://zos.alipayobjects.com/rmsportal/jeyvhMIQgoPUotNerRGy.png" alt="正确示例">
<img class="preview-img no-padding bad" align="right" src="https://zos.alipayobjects.com/rmsportal/ppdlrVnFCsYVicjDrnzi.png" alt="错误示例" description="当对比度数值低于 3:1 时,弱视用户将很难识别">

This comment has been minimized.

Copy link
@benjycui

benjycui Jun 12, 2017

Author Owner

@paranoidjk @afc163 remark@7 在处理没有被包裹的 HTML 片段时的行为与之前的不一样,导致生成的数据结构变化了,所以 ant-design/ant-design#6426

由于数据结构的改动,需要同时修改 mark-twain bisheng-plugin-antd 及用到这些库的地方,工作量略大,就先吧 remark 降级算了。

0 comments on commit ff091a0

Please sign in to comment.