POSTGRES: Use timestamptz instead of timestamp#96
Open
laterbreh wants to merge 1 commit intobenjamin-wilson:postgresqlfrom
Open
POSTGRES: Use timestamptz instead of timestamp#96laterbreh wants to merge 1 commit intobenjamin-wilson:postgresqlfrom
timestamptz instead of timestamp#96laterbreh wants to merge 1 commit intobenjamin-wilson:postgresqlfrom
Conversation
laterbreh
changed the title
timestamptz instead of timestamp so that date comparisons ar…timestamptz instead of timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
timestamptzinstead oftimestampin the postgres entities so that date comparisons are correct through out the application.timestampsaves without a timezone-- It was saving the correct UTC time but without a timezone-- so any comparisons to server time yielded incorrect values.For example this fixed the hashrate recording and dead-client removal (because the time comparisons to save hashrates/shares never saved because of a negative difference in time during the if comparisons) etc.
I've verified this change causes no side-effects or breakages in the server side application on the
postgresbranch. I believetimestamptzwas the original intention nottimestamp.I also should mention this fixed the offset that was also displaying on the public-pool-ui where database times where being displayed to the client.