fix: isolate mirror tests from host env to prevent API key leak (#522)#573
Open
ElegantLin wants to merge 1 commit into
Open
fix: isolate mirror tests from host env to prevent API key leak (#522)#573ElegantLin wants to merge 1 commit into
ElegantLin wants to merge 1 commit into
Conversation
Tests called auto_inherit_env() without clearing os.environ, so real API keys on the host would be inherited into the test env dict, causing assertion failures that leak the key value into pytest output. Add an autouse fixture using the existing _clear_keys() helper, matching the isolation pattern already used by TestResolveAgentEnvGemini. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestAutoInheritEnvBidirectionalMirrorcalledauto_inherit_env()without clearingos.environ, so real API keys (e.g.GEMINI_API_KEY) on the host leaked into the test dictautousefixture using the existing_clear_keys()helper, matching the isolation pattern already used byTestResolveAgentEnvGeminiin the same fileTest plan
test_agent_env_resolution.pypass (including the previously failingtest_gemini_only_mirrors_to_google)GEMINI_API_KEY/GOOGLE_API_KEYexported in the environmentCloses #522
🤖 Generated with Claude Code