Skip to content

fix: auto-discover task-bundled skills for oracle mode#562

Open
ElegantLin wants to merge 1 commit into
mainfrom
fix/557-oracle-bundled-skills
Open

fix: auto-discover task-bundled skills for oracle mode#562
ElegantLin wants to merge 1 commit into
mainfrom
fix/557-oracle-bundled-skills

Conversation

@ElegantLin
Copy link
Copy Markdown

@ElegantLin ElegantLin commented May 26, 2026

Summary

  • Oracle Daytona runs failed for tasks with bundled skills (environment/skills/) because deploy_skills() never detected them — _start_env_and_upload uploads them to /app/skills but effective_skills stayed None, so the symlink step to /root/.claude/skills was skipped.
  • Added auto-discovery: when no explicit skills source is found, deploy_skills() checks for task_path/environment/skills/ and links /app/skills to agent discovery paths.
  • Added two regression tests guarding auto-discovery and include_task_skills=False behavior.

Closes #557

Test plan

  • test_deploy_skills_oracle_autodiscovers_bundled_skills — oracle with bundled skills links /app/skills/root/.claude/skills
  • test_deploy_skills_autodiscovery_skipped_when_include_task_skills_false — self-gen respects include_task_skills=False
  • Full test suite passes (1368 passed, 9 pre-existing failures unrelated)
  • ty check passes

🤖 Generated with Claude Code


Open in Devin Review

Oracle Daytona runs failed for tasks with bundled skills (environment/skills/)
because deploy_skills never detected them — _start_env_and_upload uploads them
to /app/skills but the linking step was skipped since effective_skills stayed
None. Now deploy_skills auto-discovers the bundled directory and links it to
agent discovery paths (/root/.claude/skills, etc.).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@ElegantLin ElegantLin requested a review from bingran-you May 26, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oracle Daytona does not expose task-bundled skills at /root/.claude/skills, breaking 3d-scan-calc oracle

2 participants