ci: run test workflow on merge_group events#315
Open
xdotli wants to merge 1 commit into
Open
Conversation
The `test` workflow only triggered on push and pull_request, so its required status check never reported on a merge queue's merge group. Add the `merge_group` trigger so `test` runs on queued batches — a prerequisite for enabling a GitHub merge queue on `main` that gates on the `test` check.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bingran-you
added
the
review:pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
merge_group:trigger to.github/workflows/test.ymlso thetestjob runs on a merge queue's merge groups.Today
testonly triggers onpushandpull_request. If a GitHub merge queue is enabled onmainwithtestas a required status check, the check would never report on the queue's merge-group branches and entries would stall until timeout. This change makestestrun on queued batches.Context
Prerequisite for enabling a merge queue on
main(parallel to themain-merge-queueruleset already active onbenchflow-ai/skillsbench). No behavior change for normalpush/pull_requestruns.Note
Low Risk
Low risk CI-only change that only affects when the existing
testworkflow triggers; no application/runtime code is modified.Overview
Updates the GitHub Actions
testworkflow to also run onmerge_groupevents, ensuring required checks execute for GitHub merge queue batches in addition to existingpushandpull_requesttriggers.Reviewed by Cursor Bugbot for commit e8ae095. Bugbot is set up for automated code reviews on this repo. Configure here.