Restructure distance sorting JSON. #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue benashford#150, where the JSON is wrong for distance sorting. The structure is a little non-standard, as it is wrapped in an object with hardcoded _geo_distance as name. Reaching through inner-outer and tupled structs is unfortunate, but seems to be nessecary in order to keep the API the same and to keep everything nicely contained inside a GeoDistance struct as seen from the consumer or user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #150, where the JSON is wrong for distance sorting.
The structure is a little non-standard, as it is wrapped in an object
with hardcoded _geo_distance as name.
Reaching through inner-outer and tupled structs is unfortunate, but
seems to be nessecary in order to keep the API the same and to
keep everything nicely contained inside a GeoDistance struct as seen
from the consumer or user.