Skip to content

fix(classname): fix zero mod value bug #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(classname): fix zero mod value bug #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/classname/classname.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export type Preset = {
v?: string
}

function isEmpty(val: string | boolean | number | undefined) {
return !val && val !== 0
}

/**
* BEM className configure function.
*
Expand Down Expand Up @@ -81,7 +85,7 @@ export function withNaming(preset: Preset): ClassNameInitilizer {

if (modVal === true) {
className += modPrefix + k
} else if (modVal) {
} else if (!isEmpty(modVal)) {
className += modPrefix + k + modValueDelimiter + modVal
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/classname/test/classname.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('@bem-react/classname', () => {

test('zero', () => {
const b = cn('Block')
expect(b({ modName: '0' })).toEqual('Block Block_modName_0')
expect(b({ modName: '0', mod: 0 })).toEqual('Block Block_modName_0 Block_mod_0')
})

test('undefined', () => {
Expand Down Expand Up @@ -211,7 +211,7 @@ describe('@bem-react/classname', () => {

test('zero', () => {
const b = cCn('block')
expect(b({ modName: '0' })).toEqual('block block_modName_0')
expect(b({ modName: '0', mod: 0 })).toEqual('block block_modName_0 block_mod_0')
})
})
})
Expand Down