Decorate Pack as dataclass #3215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
HalfWhitt
force-pushed
the
pack-dataclass
branch
from
518dc3d to
c6cefb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based off #3213 for now)
With the aliases all defined as class attribute descriptors as of #3213, Pack can be successfully decorated as a dataclass.
The only test that fails-as-is is
test_mixin.py::test_constructor, because the auto-genereated dataclass__init__throws aTypeErrorrather than aNameErrorwhen an erroneous property name is provided. I've changed what the test looks for, and also added atry/excepttoBaseStyle's fallback__init__so that the same error is generated under Python 3.9.Edit: Huh. What are the odds, it's been exactly one year, to the day, since I started this with beeware/travertino#141. I definitely didn't anticipate how long that would take 😄
PR Checklist: