Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consider disambiguation in an album name when calculation distance #5631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kitizz
Copy link

@kitizz kitizz commented Feb 13, 2025

Description

When calculating distance between the local album name and one from a database consider the option that the disambiguation text has been included in the local album's name.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

When calculating distance between the local album name and one from a database
consider the option that the disambiguation text has been included in the
local album's name.
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@kitizz
Copy link
Author

kitizz commented Feb 13, 2025

Hello! Before I take this across the line, I just wanted to make sure if this is a change you're comfortable with. And that I went about it in a way that fits with the project's style. Maybe this behavior should be flagged based on a new config option in match?

Thanks for such an awesome tool. Very glad to be able to contribute to it! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant