Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter albums by tracks fields and vice versa #5327

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

snejus
Copy link
Member

@snejus snejus commented Jun 20, 2024

Fixes #4360

This PR enables querying albums by track fields and tracks by album fields, and speeds up querying albums by path field.

It originally was part of #5240, however we found that the changes related to the flexible attributes caused degradation in performance. So this PR contains the first part of #5240 which joined items and albums tables in queries.

@snejus snejus self-assigned this Jun 20, 2024
@snejus snejus requested a review from Serene-Arc June 20, 2024 03:26
@snejus snejus force-pushed the filter-by-related-attributes branch 3 times, most recently from f302453 to 323f17c Compare June 20, 2024 04:01
@snejus snejus changed the base branch from revert-only-fast-queries to master June 20, 2024 10:31
@snejus snejus force-pushed the filter-by-related-attributes branch from 323f17c to 163cfbb Compare June 21, 2024 07:49
@snejus snejus force-pushed the filter-by-related-attributes branch from 163cfbb to bcc2826 Compare June 21, 2024 14:05
Copy link
Contributor

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original PR, the interface for field was reverted back, can we do that for this one as well? Just in case that any third-part plugins use it.

@snejus
Copy link
Member Author

snejus commented Jun 24, 2024

In the original PR, the interface for field was reverted back, can we do that for this one as well? Just in case that any third-part plugins use it.

It already has this change. Although not as a separate commit but fused into bcc2826

@snejus snejus requested a review from Serene-Arc June 24, 2024 13:12
Copy link
Contributor

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake! Looks fine to merge then

@snejus snejus merged commit 4e06b59 into master Jun 25, 2024
12 checks passed
@snejus snejus deleted the filter-by-related-attributes branch June 25, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beet list -a path:some/path queries are extremely slow
2 participants