Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests + update dependencies (bedita/php-sdk) #92

Merged
merged 17 commits into from
Sep 9, 2024

Conversation

didoda
Copy link
Member

@didoda didoda commented Sep 5, 2024

Temporarily using fork didoda/php-sdk to test bedita/php-sdk#38

Bonus: add unit tests to reach 100% code coverage

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9b3a0c) to head (cc4492e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master       #92      +/-   ##
=============================================
+ Coverage     92.24%   100.00%   +7.75%     
+ Complexity      241       235       -6     
=============================================
  Files            26        26              
  Lines           748       724      -24     
=============================================
+ Hits            690       724      +34     
+ Misses           58         0      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda changed the title dependencies: update bedita/php-sdk Add tests + update dependencies (bedita/php-sdk) Sep 6, 2024
@didoda didoda marked this pull request as ready for review September 9, 2024 12:54
@didoda didoda merged commit 38f43b0 into bedita:master Sep 9, 2024
13 checks passed
@didoda didoda deleted the feat/new-bedita-client branch September 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant