Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Apple Sign-In via OAuth2 #90

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Handle Apple Sign-In via OAuth2 #90

merged 6 commits into from
Mar 20, 2024

Conversation

stefanorosanelli
Copy link
Member

@stefanorosanelli stefanorosanelli commented Mar 19, 2024

This PR provides changes to OAuth2Authenticator class to support Apple Sign-In process, where:

  • a JWT leeway configuration may be needed
  • return call from authorization URL is performed via POST
  • id_token must be used for user verification

@stefanorosanelli stefanorosanelli changed the title feat: handle Apple auth Handle Apple Sign-In via OAuth2 Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (6131a1a) to head (e555107).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     92.17%   92.24%   +0.07%     
- Complexity      238      241       +3     
============================================
  Files            26       26              
  Lines           741      748       +7     
============================================
+ Hits            683      690       +7     
  Misses           58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanorosanelli stefanorosanelli marked this pull request as ready for review March 20, 2024 08:46
@stefanorosanelli stefanorosanelli requested a review from didoda March 20, 2024 09:42
@batopa batopa merged commit e9b3a0c into master Mar 20, 2024
27 checks passed
@batopa batopa deleted the feat/oauth2-apple branch March 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants