Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags api calls return 401 for non admin users #1241

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

didoda
Copy link
Member

@didoda didoda commented Mar 13, 2025

This fixes an issue when using ajax calls /api/model/*, in pages that can access "non admin" authenticated users: for them, the api calls return a 401 Unauthorized.

This provides the fix: do not call /api/model/* from vuejs vue, use explicit new routes for tags.

@didoda didoda added bug Something isn't working release:patch labels Mar 13, 2025
@didoda didoda added this to the 5.x milestone Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (366016e) to head (aefd3ee).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1241   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1352      1360    +8     
===========================================
  Files             97        97           
  Lines           5315      5374   +59     
===========================================
+ Hits            5315      5374   +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didoda didoda merged commit 9c73a54 into bedita:master Mar 13, 2025
9 checks passed
@didoda didoda deleted the fix/tags-api-calls-401 branch March 13, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant