-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast create object #1225
Merged
Merged
Fast create object #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
=========================================
Coverage 99.66% 99.66%
Complexity 1351 1351
=========================================
Files 98 98
Lines 5327 5327
=========================================
Hits 5309 5309
Misses 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a change in "fast creation" of objects, that was available in side panel, on relation add objects flow.
The fast creation form UI has been completely redesigned and it's available in the main view page, contextual to each relation section.
Permissions
Fast creation section is visible only if authenticated user has "write" permissions on the module, and the allowed types (modules) selectable are the ones the user has write access to.
I18n
Fields labels are translated getting i18n data from BEM or plugin(s).
Customization
You can customize it, if you want, using the configuration
UI.fast_create_form._element
. Example:User interface
When you click on the area (as suggested by the main message), you can start by selecting the object type (the list of types depends on the specific relation), or you see directly a form, when only one object type is available as "right" element for the relation.
The form data depends on the selected type (you can customize it using
Properties.<objectType>.fastCreate
configuration, see https://github.com/bedita/manager/wiki/Setup:-Properties-display#fastcreate).There is a basic validation: "Save" is disabled if you do not fill all required fields.
When you save, the new item is added in the relation section... ready to be saved as a new related item.