Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary failed save form data session handling #1198

Merged

Conversation

stefanorosanelli
Copy link
Member

@stefanorosanelli stefanorosanelli commented Oct 31, 2024

This PR removes the in-session handling of form data that previously caused server-side errors.

The issue was as follows: when a server-side error occurred while saving an object, the problematic form was displayed after showing the error message. However, upon reloading the object detail page, the form still displayed the erroneous data rather than the current data from the database, as expected. A second reload was required to display the correct data.

Since saving errors are now managed via AJAX, it’s no longer necessary to retain the erroneous data on reload. The in-session handling has therefore been removed.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (669fbff) to head (62e2b3c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1198      +/-   ##
============================================
- Coverage     99.70%   99.65%   -0.06%     
- Complexity     1310     1326      +16     
============================================
  Files            97       98       +1     
  Lines          5113     5205      +92     
============================================
+ Hits           5098     5187      +89     
- Misses           15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanorosanelli stefanorosanelli added bug Something isn't working release:patch labels Oct 31, 2024
@didoda didoda marked this pull request as ready for review October 31, 2024 10:35
@didoda didoda changed the title fix: remove unnecessary failed save form data session handling Remove unnecessary failed save form data session handling Oct 31, 2024
@didoda didoda merged commit b3e5552 into bedita:master Oct 31, 2024
13 of 14 checks passed
@didoda didoda deleted the fix/remove-failedsave-session branch October 31, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants