Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use objects endpoint to search by type #1080

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

didoda
Copy link
Member

@didoda didoda commented Jan 29, 2024

This provides a fix in object(s) side panel search by calling a GET /objects?filter[type][]=... instead of GET /<type>.

Bonus: minor ui fix for roles list view in user view.

@didoda didoda added bug Something isn't working Priority - High release:patch labels Jan 29, 2024
@didoda didoda added this to the 4.x milestone Jan 29, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c18e5f) 99.67% compared to head (53f05fb) 99.67%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1080      +/-   ##
============================================
- Coverage     99.67%   99.67%   -0.01%     
+ Complexity     1169     1168       -1     
============================================
  Files            91       91              
  Lines          4610     4608       -2     
============================================
- Hits           4595     4593       -2     
  Misses           15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda merged commit 36fa63d into bedita:master Jan 31, 2024
22 checks passed
@didoda didoda deleted the fix/search-by-type branch January 31, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant