Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input number attribute step #1079

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

didoda
Copy link
Member

@didoda didoda commented Jan 29, 2024

<input type="number"> doesn't allow to save when value is a float (browser validation blocks).

This provides a fix:

  • when object field is an integer: <input type="number" step="1">
  • when object field is a float: <input type="number" step="any">

@didoda didoda added bug Something isn't working Priority - High labels Jan 29, 2024
@didoda didoda added this to the 4.x milestone Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98a0dbb) 99.67% compared to head (864e687) 99.67%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1079   +/-   ##
=========================================
  Coverage     99.67%   99.67%           
- Complexity     1166     1169    +3     
=========================================
  Files            91       91           
  Lines          4603     4610    +7     
=========================================
+ Hits           4588     4595    +7     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda marked this pull request as ready for review January 29, 2024 12:28
@stefanorosanelli stefanorosanelli merged commit 4c18e5f into bedita:master Jan 29, 2024
17 checks passed
@stefanorosanelli stefanorosanelli deleted the fix/input-number-step branch January 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants