Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s packaging metadata by loosening the runtime dependency constraint on PySide6, broadening the range of supported Qt/PySide6 versions for qtmonaco.
Changes:
- Remove the PySide6 upper bound (
<=6.9.0) and keep only a minimum version requirement (>=6.8).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| ] | ||
| dependencies = [ | ||
| "PySide6>=6.8,<=6.9.0", | ||
| "PySide6>=6.8", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing BW with newest PySide and this one keeps me from running CI: https://github.com/bec-project/bec_widgets/actions/runs/23198413041/job/67413324545?pr=1103#logs