fix(positioner_box): remove CompactPopupWidget inheritance#1111
Open
wyzula-jan wants to merge 1 commit intomainfrom
Open
fix(positioner_box): remove CompactPopupWidget inheritance#1111wyzula-jan wants to merge 1 commit intomainfrom
wyzula-jan wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes CompactPopupWidget inheritance from the PositionerBox widget hierarchy to resolve layout issues, and updates dependent widgets/tests accordingly. This supports follow-up work needed for #1105.
Changes:
- Drop
CompactPopupWidgetfromPositionerBoxBaseand replace the previous container/layout plumbing with an explicitmain_layout. - Update
PositionerBox,PositionerBox2D, andPositionerGroupBoxto stop using compact-popup-specific APIs/signals. - Adjust
PositionerControlLineUI/layout behavior and update unit tests to reflect new module paths and sizing expectations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit_tests/test_positioner_box_2d.py | Updates patch targets to the new positioner_box_base module path. |
| tests/unit_tests/test_positioner_box.py | Updates patch targets and relaxes/aligns height assertions with the new layout behavior. |
| bec_widgets/widgets/control/device_control/positioner_group/positioner_group.py | Removes compact-popup configuration and expand handling now that the base no longer supports it. |
| bec_widgets/widgets/control/device_control/positioner_box/positioner_control_line/positioner_control_line.ui | Updates size policies/margins to better support the one-line layout. |
| bec_widgets/widgets/control/device_control/positioner_box/positioner_control_line/positioner_control_line.py | Adds responsive layout/orientation logic for the indicator and fixed-height line behavior. |
| bec_widgets/widgets/control/device_control/positioner_box/positioner_box_base.py | Removes CompactPopupWidget inheritance and introduces an explicit main_layout. |
| bec_widgets/widgets/control/device_control/positioner_box/positioner_box_2d/positioner_box_2d.py | Switches to main_layout and removes compact-popup label usage. |
| bec_widgets/widgets/control/device_control/positioner_box/positioner_box/positioner_box.py | Switches to main_layout and removes compact-popup label initialization. |
| bec_widgets/widgets/control/device_control/positioner_box/_base/init.py | Removes the deprecated _base package export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CompactPopup inheritance was messing up layout of the widget. Since the CompactPopupWidget is not used in any production, we can get rid of it for now.
Needed for #1105